Add normalized document provider to allow caching of normalized documents#4048
Closed
timward60 wants to merge 3 commits intographql-java:masterfrom
Closed
Add normalized document provider to allow caching of normalized documents#4048timward60 wants to merge 3 commits intographql-java:masterfrom
timward60 wants to merge 3 commits intographql-java:masterfrom
Conversation
da290e2 to
bdc9f7c
Compare
bbakerman
reviewed
Jul 14, 2025
bbakerman
reviewed
Jul 14, 2025
bbakerman
reviewed
Jul 14, 2025
86bb621 to
fbb6e8b
Compare
fbb6e8b to
16b0262
Compare
16b0262 to
8e2e760
Compare
dondonz
reviewed
Jul 20, 2025
| this.executionInput = builder.executionInput; | ||
| this.dataLoaderDispatcherStrategy = builder.dataLoaderDispatcherStrategy; | ||
| this.queryTree = FpKit.interThreadMemoize(() -> ExecutableNormalizedOperationFactory.createExecutableNormalizedOperation(graphQLSchema, operationDefinition, fragmentsByName, coercedVariables)); | ||
| this.queryTree = FpKit.interThreadMemoize(() -> this. createGraphQLNormalizedOperation().join()); |
Member
There was a problem hiding this comment.
Super nit: there's a space after this.
Contributor
|
Hello, this pull request has been inactive for 60 days, so we're marking it as stale. If you would like to continue working on this pull request, please make an update within the next 30 days, or we'll close the pull request. |
Contributor
|
Hello, as this pull request has been inactive for 90 days, we're closing this pull request. We always welcome contributions, and if you would like to continue, please open a new pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables:
NormalizedDocumentimplementation behind an experimental API configuration.There a few things that could be improved, but would require larger more broader changes, including: