Support @deprecated on arguments and input fields#696
Merged
oryan-block merged 1 commit intographql-java-kickstart:masterfrom Sep 14, 2022
Conversation
ajkerr
commented
Sep 13, 2022
cc01a65 to
58c6224
Compare
oryan-block
requested changes
Sep 13, 2022
Collaborator
oryan-block
left a comment
There was a problem hiding this comment.
Thanks for adding tests. I just have a couple requests.
58c6224 to
4f15c60
Compare
4f15c60 to
04544ec
Compare
Contributor
Author
|
I created a corresponding PR to update the documentation here: graphql-java-kickstart/documentation#37 |
oryan-block
approved these changes
Sep 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the
@deprecateddirective on arguments and input fields.Support for this was added in version 17.0 of
graphql-java.Checklist
Description
Fairly simple changes - I added support for this to the main
SchemaParserclass, and added tests for the new and previously-existing functionality.