WebsocketSession.readFrame() should batch read payload bytes.#387
Merged
Vkt0r merged 1 commit intohttpswift:stablefrom Apr 15, 2019
Merged
WebsocketSession.readFrame() should batch read payload bytes.#387Vkt0r merged 1 commit intohttpswift:stablefrom
WebsocketSession.readFrame() should batch read payload bytes.#387Vkt0r merged 1 commit intohttpswift:stablefrom
Conversation
Contributor
Author
|
Hello, I didn't see any contribution guidelines but made this fix that I think others may find useful. Let me know if there's anything you'd like me to change about the PR. Also: Thanks for making such a nice library and sharing it with everyone! |
This is much faster than calling `socket.read()` to read byte-by-byte. I believe this is the same issue raised here: httpswift#314
Member
tomieq
pushed a commit
to tomieq/swifterfork
that referenced
this pull request
Apr 1, 2021
`WebsocketSession.readFrame()` should batch read payload bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is much faster than calling
socket.read()to read byte-by-byte.I believe this is the same issue raised here: #314