Conversation
fkiraly
requested changes
Jul 6, 2025
Collaborator
fkiraly
left a comment
There was a problem hiding this comment.
Ouch! This looks absolutely painful!
We should test this - I think feature-engine tests 1.5, 1.6, and 1.7.
Could be a separate matrix to avoid proliferation of matrices, e.g., combinations of sklearn and python version, but only on one OS.
Collaborator
|
minor comment, I would give the test a name which includes matrix elements, so it appears like (3.10, macos-latest) in the other tests. Otherweise we have five jobs named test-sklearn-1.7 |
fkiraly
added a commit
that referenced
this pull request
Jul 29, 2025
PR #138 added support for `scikit-learn 1.7.X`, but the bound in `pyproject.toml` was not raised - this PR increases that bound.
fkiraly
added a commit
that referenced
this pull request
Jul 30, 2025
PR #138 added support for `scikit-learn 1.7.X`, but the bound in `pyproject.toml` was not raised - this PR increases that bound.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #128.
Compatibility functions for v1.6 and v1.7 of sklearn in hyperactive.integrations.sklearn._compat.py