fix: remove parentheses from ENV in Dockerfile#7709
Open
error1001es wants to merge 1 commit intohyperf:masterfrom
Open
fix: remove parentheses from ENV in Dockerfile#7709error1001es wants to merge 1 commit intohyperf:masterfrom
error1001es wants to merge 1 commit intohyperf:masterfrom
Conversation
…ral parsing fix: remove parentheses from ENV in Dockerfile to prevent string literal parsing
Author
|
Also updated the dev Dockerfile to maintain consistency. Using (false) as a string literal in ENV causes it to be evaluated as true in PHP's loose typing, which defeats the purpose of disabling the cache in development. "dev.Dockerfile" |
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove parentheses from ENV in Dockerfile to prevent string literal parsing
➜ hyperf-test docker build -t hyperftest:v1.0.1 .➜ hyperf-test docker run --rm --entrypoint php hyperftest:v1.0.1 -r "var_dump(getenv('SCAN_CACHEABLE'));"string(6) "(true)"