Support headerless format in getFrameParameters and decompress#217
Closed
swehner wants to merge 4 commits intoindygreg:mainfrom
Closed
Support headerless format in getFrameParameters and decompress#217swehner wants to merge 4 commits intoindygreg:mainfrom
swehner wants to merge 4 commits intoindygreg:mainfrom
Conversation
swehner
commented
Mar 16, 2024
|
|
||
| for i, frame in enumerate(result): | ||
| self.assertEqual(dctx.decompress(frame), original[i]) | ||
| self.assertEqual(dctx.decompress(frame.tobytes()), original[i]) |
Contributor
Author
There was a problem hiding this comment.
With the rust backend the test was erroring out becase frame wasn't a buffer but a zstandard.backend_rust.BufferSegment - not sure what the best way to fix it is...
This does work, so I added the conversion
swehner
commented
Mar 16, 2024
Comment on lines
+4
to
+5
| [target.aarch64-apple-darwin] | ||
| rustflags = ["-C", "link-arg=-undefined", "-C", "link-arg=dynamic_lookup"] |
Contributor
Author
There was a problem hiding this comment.
For compiling on M1
indygreg
approved these changes
Aug 17, 2025
Owner
indygreg
left a comment
There was a problem hiding this comment.
Thank you for the feature addition!
I'm going to cherry pick this change locally, fix the bit rot, then push it for you. The PR will be marked as closed but it will be merged in effect. This will be in a release this weekend unless I run into trouble with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for magic-less format in a few functions:
formatto get_frame_paramaters and switch to usinggetFrameHeader_advancedinternallygetFrameHeader_advancedin decompress instead ofgetFrameContentSizeTesting done: