Closed
Conversation
tdltdl
commented
Sep 11, 2024
- Remove deprecated code
- upgrade dependencies (amongst other to fix CVE)
- fix typos
- fix tests expected result based on current results from IPInfo
- ordered the parameters correctly
- add comment for failed test case to know which test is failing
Contributor
Contributor
|
@tdltdl similarly, this PR hasn't been addressed. Closing for now. Will let @silvanocerza decide if he wants to reopen it with some of the suggestions initially given. |
Author
|
Again here proposed a fix to CVEs and made the test assertion right, on Sept 2024, and Feb 2025 maintainer do some changes without merging first and expect volunteers to redo their work that was stale for more than 5 months. I am not sure you are welcoming volunteer help on this project. |
Contributor
|
@tdltdl I am sorry for your experience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.