Skip to content

Support Swift 5.0#268

Merged
ikesyo merged 18 commits intoishkawa:masterfrom
E13Lau:develop-Swift5
Apr 12, 2019
Merged

Support Swift 5.0#268
ikesyo merged 18 commits intoishkawa:masterfrom
E13Lau:develop-Swift5

Conversation

@E13Lau
Copy link
Contributor

@E13Lau E13Lau commented Apr 2, 2019

No description provided.

@E13Lau E13Lau closed this Apr 3, 2019
@E13Lau E13Lau reopened this Apr 3, 2019
Copy link
Collaborator

@ikesyo ikesyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this! Could you please rebase onto current master to include the changes in #270?

@E13Lau
Copy link
Contributor Author

E13Lau commented Apr 8, 2019

Has fix.

Fixed requirements.
@ikesyo
Copy link
Collaborator

ikesyo commented Apr 9, 2019

Looks like you didn't successfully resolved the conflicts, please merge upstream's master or rebase.

@E13Lau
Copy link
Contributor Author

E13Lau commented Apr 9, 2019

Mabey don't need 'osx_image: xcode10.1, osx_image: xcode9.4, osx_image: xcode9.2' in .travis.yml file

Copy link
Collaborator

@ikesyo ikesyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be good now.

@ikesyo ikesyo merged commit 862a8f8 into ishkawa:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants