Update PULL_REQUEST_TEMPLATE.md to include issue cross-reference.#25737
Merged
QuLogic merged 2 commits intomatplotlib:mainfrom Apr 22, 2023
Merged
Update PULL_REQUEST_TEMPLATE.md to include issue cross-reference.#25737QuLogic merged 2 commits intomatplotlib:mainfrom
QuLogic merged 2 commits intomatplotlib:mainfrom
Conversation
This changes the PR template to prompt/remind the user to link the issue it resolves. This is to make sure that it reduces duplicate PRs, as having a back link would make it easier to know that there's work being done on a particular issue.
story645
reviewed
Apr 20, 2023
Member
story645
left a comment
There was a problem hiding this comment.
I'm wondering also if we can use githubs form schema and make this a required text area.
Contributor
Author
It doesn't have to be necessary because that might hamper just normal MNT PRs or something that's not related to the issue. |
QuLogic
approved these changes
Apr 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the PR template to prompt/remind the user to link the issue it resolves. This is to make sure that it reduces duplicate PRs, as having a back link would make it easier to know that there's work being done on a particular issue.
PR Summary
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst