Add an 'extra' optional, orjson to experiment with rust speedups#64
Open
realtyem wants to merge 10 commits intomatrix-org:mainfrom
Open
Add an 'extra' optional, orjson to experiment with rust speedups#64realtyem wants to merge 10 commits intomatrix-org:mainfrom
orjson to experiment with rust speedups#64realtyem wants to merge 10 commits intomatrix-org:mainfrom
Conversation
…f 2, so adjust a test
…ew orjson extra option
…immutabledict and add this as a test Side effect: drop in support for anything Synapse registers
anoadragon453
requested changes
Sep 18, 2025
Member
anoadragon453
left a comment
There was a problem hiding this comment.
Thanks for this! To move this along, could you:
- Separate out dropping Python 3.7 support (it's been EOL for a while, so we should drop it across the repo) into a new PR?
- Remove the base vs. orjson tox config now (including coverage changes) as we have seen an improvement in the test case runtimes 🎉
Comment on lines
+111
to
+112
| # orjson's pretty print style is a flag option and is hardcoded to "2", | ||
| # so this will be slightly different. |
Member
There was a problem hiding this comment.
It might be worth proposing an OPT_INDENT_4 to upstream?
It's not ideal that we'll be changing the output of encode_pretty_printed_json (in case it breaks downstream test cases), but it's possible with a version bump/note in the changelog.
Comment on lines
+156
to
+197
| data_with_inf = {"a": 1, "b": float("inf")} | ||
| data_with_neg_inf = {"a": 1, "b": -float("inf")} | ||
| data_with_nan = {"a": 1, "b": float("nan")} | ||
| list_with_inf = {"a": [1, float("inf")]} | ||
| list_with_neg_inf = {"a": [1, -float("inf")]} | ||
| list_with_nan = {"a": [1, float("nan")]} | ||
|
|
||
| with self.assertRaises(ValueError): | ||
| encode_canonical_json(data_with_inf) | ||
|
|
||
| with self.assertRaises(ValueError): | ||
| encode_pretty_printed_json(data_with_inf) | ||
|
|
||
| with self.assertRaises(ValueError): | ||
| encode_canonical_json(data_with_neg_inf) | ||
|
|
||
| with self.assertRaises(ValueError): | ||
| encode_pretty_printed_json(data_with_neg_inf) | ||
|
|
||
| with self.assertRaises(ValueError): | ||
| encode_canonical_json(data_with_nan) | ||
|
|
||
| with self.assertRaises(ValueError): | ||
| encode_pretty_printed_json(data_with_nan) | ||
|
|
||
| with self.assertRaises(ValueError): | ||
| encode_canonical_json(list_with_inf) | ||
|
|
||
| with self.assertRaises(ValueError): | ||
| encode_pretty_printed_json(list_with_inf) | ||
|
|
||
| with self.assertRaises(ValueError): | ||
| encode_canonical_json(list_with_neg_inf) | ||
|
|
||
| with self.assertRaises(ValueError): | ||
| encode_pretty_printed_json(list_with_neg_inf) | ||
|
|
||
| with self.assertRaises(ValueError): | ||
| encode_canonical_json(list_with_nan) | ||
|
|
||
| with self.assertRaises(ValueError): | ||
| encode_pretty_printed_json(list_with_nan) |
Member
There was a problem hiding this comment.
This would be more readable if the test cases were looped over, i.e.:
test_cases = {
"data_with_inf": {"a": 1, "b": float("inf")},
...
}
for name, test_case in test_cases.items():
with self.assertRaises(ValueError, f"Passing test case '{name}' to encode_canonical_json failed to raise a ValueError"):
encode_canonical_json(test_case)
with self.assertRaises(ValueError, f"Passing test case '{name}' to encode_pretty_printed_json failed to raise a ValueError"):
encode_pretty_printed_json(test_case)
Author
There was a problem hiding this comment.
Oh, I like that. Yes, will do 🫡
Author
For clarity... And for the second bit, just have only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
orjsonproject reports a(sometimes several) order of magnitude speed up in serializing/deserializing JSON. Let's try it out