Proposal: split train.py into train.py and train_aml.py#219
Merged
Conversation
dtzar
approved these changes
Mar 2, 2020
Contributor
dtzar
left a comment
There was a problem hiding this comment.
LGTM - I'd probably wait to merge this until you have the Juypter notebook equivalent of train_aml.py flushed out in conjunction with this.
eedorenko
approved these changes
Mar 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change splits train.py into two files.
The new train.py is standalone, and has no references to AzureML. It defines two functions, split_data to split a dataframe into test/train data, and train_model which takes the test/train data and a parameter object and trains the model and returns related metrics. The script can be run locally, in which case it loads a dataset from a file.
The second file, train_aml.py contains reasonably general AzureML logic. It reads data from a dataset, then calls the split_data function from train.py. It loads input parameters from a config file and logs them, then calls train_model from train.py. It then uploads the model and logs any metrics returned by train_model.
The hope with these changes is to demonstrate a simple interface for integrating an existing ML script with MLOpsPython, as well as providing an example for how the core ML functionality can be invoked in multiple ways for development purposes.