Casey's miscellaneous branch#3293
Merged
StephanTLavavej merged 5 commits intomicrosoft:mainfrom Jan 11, 2023
Merged
Conversation
* MSVC has fixed `__is_aggregate`, so we can disable the workaround for internal testing. * Clang has implemented the `__is_aggregate` fix. * I filed VSO-1690654 to request a similar fix for EDG. Update the TRANSITION comment for the workaround appropriatelu.
IIRC I added this while speculatively implementing the PR of an LWG issue that was later changed to no longer need _`to-signed-like`_.
StephanTLavavej
approved these changes
Dec 16, 2022
…ME.md ... and use it to simplify the example.
StephanTLavavej
approved these changes
Dec 16, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Miscellaneous thanks! 😹 🐈 🐈⬛ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some changes too small to submit individually that I've been accumulating.
ranges_algorithm_support.hppincludes<cstddef>but usessize_tunqualified; addstd::-qualifications.__is_aggregate, but EDG has not. Disable the workaround in internal testing to avoid regression, and update the TRANSITION comment appropriately._To_signed_likeis unused, remove it._Verify_offsetis called on an invalidatedvectoriterator.set_environment.batinREADME.md, and use it in the "How To Consume" example.