_Weakly_unwrappable should use _Allow_inheriting_unwrap_v#3566
Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom Mar 17, 2023
Merged
_Weakly_unwrappable should use _Allow_inheriting_unwrap_v#3566StephanTLavavej merged 1 commit intomicrosoft:mainfrom
_Weakly_unwrappable should use _Allow_inheriting_unwrap_v#3566StephanTLavavej merged 1 commit intomicrosoft:mainfrom
Conversation
... so as not to require `_Prevent_inheriting_unwrap`. The intent of the unwrapping design is that `_Prevent_inheriting_unwrap` is optional.
Weakly_unwrappable should use _Allow_inheriting_unwrap_v
Contributor
|
I'm happy either way, although slight preference for |
StephanTLavavej
approved these changes
Mar 13, 2023
Member
|
I prefer the typedef to be optional, as this asks user-defined iterators to do less work. Inheriting from an iterator is squirrely and most code doesn't need to worry about that scenario. |
barcharcraz
approved these changes
Mar 14, 2023
Contributor
barcharcraz
left a comment
There was a problem hiding this comment.
I kinda like it being optional, as well.
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Weakly_unwrappable should use _Allow_inheriting_unwrap_v_Weakly_unwrappable should use _Allow_inheriting_unwrap_v
Member
|
Thanks for fixing this bug! 🐞 🐈⬛ 😻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... so as not to require
_Prevent_inheriting_unwrap; the intent of the unwrapping design is that_Prevent_inheriting_unwrapis optional.I'm willing to be convinced that
_Prevent_inheriting_unwrapshould be made mandatory, in which case we should still accept this change and also make changes to_Allow_inheriting_unwrap_vto maintain consistency between Ranges and non-Ranges unwrapping machinery.