Ensure _Idx is only worked on if it has to be.#3658
Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom Apr 28, 2023
Merged
Ensure _Idx is only worked on if it has to be.#3658StephanTLavavej merged 1 commit intomicrosoft:mainfrom
StephanTLavavej merged 1 commit intomicrosoft:mainfrom
Conversation
I don't know if whatever compile is supposed to compile this will notice, but this is the only place where this structure appears, so it seems best that the incrementation be done within the loop.
strega-nil-ms
approved these changes
Apr 20, 2023
Contributor
strega-nil-ms
left a comment
There was a problem hiding this comment.
Small change, but appreciated.
StephanTLavavej
approved these changes
Apr 20, 2023
Member
|
This is correct (no effective behavioral change) because |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for cleaning up this code! 🧹 🐱 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if whatever compile is supposed to compile this will notice, but this is the only place where this structure appears, so it seems best that the incrementation be done within the loop.