Introduce _Is_transparent helper trait#3736
Merged
StephanTLavavej merged 3 commits intomicrosoft:mainfrom Jun 15, 2023
Saalvage:is_transparent_helper
Merged
Introduce _Is_transparent helper trait#3736StephanTLavavej merged 3 commits intomicrosoft:mainfrom Saalvage:is_transparent_helper
_Is_transparent helper trait#3736StephanTLavavej merged 3 commits intomicrosoft:mainfrom
Saalvage:is_transparent_helper
Conversation
Also a concept for future-proofing.
…if_t` where it is used
StephanTLavavej
approved these changes
May 30, 2023
Member
|
This is an excellent refactoring, thank you! The SFINAE was more complicated than I remembered, and the way you're simplifying it is great. (It was weird/unusual to be doing SFINAE with separate template parameters.) I've pushed a small change to move code around for increased throughput. |
CaseyCarter
approved these changes
May 31, 2023
strega-nil-ms
approved these changes
Jun 12, 2023
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for making this code so clear! 😹 🔭 🎉 |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And properly standardize some SFINAE using it.
I would like to utilize this helper in implementing
flat_set.