Strengthen exception specification for complex#3880
Merged
StephanTLavavej merged 8 commits intomicrosoft:mainfrom Jul 26, 2023
Merged
Strengthen exception specification for complex#3880StephanTLavavej merged 8 commits intomicrosoft:mainfrom
complex#3880StephanTLavavej merged 8 commits intomicrosoft:mainfrom
Conversation
Conditional `noexcept` specifications make the strengthening only applied to `complex<float>`, `complex<double>`, and `complex<long double>`.
strega-nil-ms
approved these changes
Jul 21, 2023
Contributor
strega-nil-ms
left a comment
There was a problem hiding this comment.
This looks good to me!
Member
StephanTLavavej
left a comment
There was a problem hiding this comment.
Thanks! I'll validate and push changes...
StephanTLavavej
approved these changes
Jul 21, 2023
Member
|
@strega-nil-ms FYI, I pushed minor fixes and moderate-size Also, I noticed that |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
🦾 🧮 🧑🏫 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conditional
noexceptspecifications make the strengthening only applied tocomplex<float>,complex<double>, andcomplex<long double>. Not sure whether unconditionalnoexceptwould be better (should be OK sincecomplex<SomeOtherType>has unspecified effects).This PR is currently adding
noexceptto some internal functions declared in<ymath.h>and some other functions called by them. I hope this is not too aggressive.