Remove /clr test workarounds#4012
Merged
StephanTLavavej merged 2 commits intomicrosoft:mainfrom Sep 7, 2023
Merged
Conversation
CaseyCarter
approved these changes
Sep 6, 2023
Member
Author
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to Shayne Hiet-Block's wonderful internal MSVC-PR-487530, we can remove numerous test workarounds for the following internal bugs:
/clrsilent bad codegen withstd::_Signed128multiplication/clrSystem.AccessViolationException with parallelstd::mismatch/clrx86 runtime assertions/crashes with parallel algorithms/clrC++20 x86 System.AccessViolationException withatomic<shared_ptr>/clrC++20 x64 System.AccessViolationException withviews::iotaandviews::transform/clrC++20 System.AccessViolationException with ranges uninitialized algorithmsI had to report and add a highly targeted workaround for one remaining bug:
/clrC++20 x86 System.AccessViolationException withatomic<with_padding_bits<8>>Because
/clrisn't built on GitHub (yet), we can immediately remove these workarounds and "lock in" the fixes, without waiting for a VS Preview to ship.