<atomic>: Add missing atomic& operator=(const atomic&) volatile = delete; overload#4287
Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom Jan 9, 2024
Merged
Conversation
59b7141 to
acd6c34
Compare
fsb4000
approved these changes
Dec 30, 2023
CaseyCarter
approved these changes
Jan 3, 2024
StephanTLavavej
approved these changes
Jan 8, 2024
Member
|
I verified that there are two unaffected partial specializations (in the Standard and our implementation): |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for investigating these libcxx failures and improving |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per [atomics.types.generic.general], [atomics.types.int], [atomics.types.float], and [atomics.types.pointer], this overload exists for all specializations.
Unblocks two libcxx tests:
std/atomics/atomics.types.generic/atomics.types.float/copy.compile.pass.cppstd/atomics/atomics.types.generic/copy_semantics_traits.pass.cpp