Run CTest tests serially to avoid oversubscribing cores#4335
Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom Jan 25, 2024
horenmar:devel-serial-ctest-tests
Merged
Run CTest tests serially to avoid oversubscribing cores#4335StephanTLavavej merged 1 commit intomicrosoft:mainfrom horenmar:devel-serial-ctest-tests
StephanTLavavej merged 1 commit intomicrosoft:mainfrom
horenmar:devel-serial-ctest-tests
Conversation
The lit tests are already internally parallelized, so using CTest to run them in parallel ends up with the CPU cores hopelessly oversubscribed.
fsb4000
approved these changes
Jan 21, 2024
Contributor
fsb4000
left a comment
There was a problem hiding this comment.
I've checked that the CI time doesn't change after the update, and I also consulted the CMake documentation to ensure there were no misspellings:
https://cmake.org/cmake/help/latest/command/set_tests_properties.html
https://cmake.org/cmake/help/latest/prop_test/RUN_SERIAL.html
StephanTLavavej
approved these changes
Jan 21, 2024
Member
|
Thanks! I never run |
CaseyCarter
approved these changes
Jan 22, 2024
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks again! 🎉 😸 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lit tests are already internally parallelized, so using CTest to run them in parallel ends up with the CPU cores hopelessly oversubscribed.