<new>: SRWLOCK to protect the new handler instead of an indexed CRITICAL_SECTION#4407
Merged
StephanTLavavej merged 4 commits intomicrosoft:mainfrom Feb 27, 2024
Merged
<new>: SRWLOCK to protect the new handler instead of an indexed CRITICAL_SECTION#4407StephanTLavavej merged 4 commits intomicrosoft:mainfrom
<new>: SRWLOCK to protect the new handler instead of an indexed CRITICAL_SECTION#4407StephanTLavavej merged 4 commits intomicrosoft:mainfrom
Conversation
...instead of an indexed `CRITICAL_SECTION`
StephanTLavavej
approved these changes
Feb 22, 2024
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for noticing and improving the performance here! 🦅 👁️ 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3521
After finally making both constructor of
std::mutexconstexprand its destructor trivial, it is should be fine to use usual mutexes everywhere!