Enforce std::time_base::mdy for "C" locale#4437
Merged
StephanTLavavej merged 5 commits intomicrosoft:mainfrom Mar 8, 2024
Merged
Enforce std::time_base::mdy for "C" locale#4437StephanTLavavej merged 5 commits intomicrosoft:mainfrom
std::time_base::mdy for "C" locale#4437StephanTLavavej merged 5 commits intomicrosoft:mainfrom
Conversation
StephanTLavavej
approved these changes
Mar 5, 2024
Member
|
I believe this behavioral change is desirable - we'll properly detect when we should be using the "C" locale, instead of picking up |
Member
|
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for investigating and fixing this longstanding bug that was affecting several contributors! 🌎 🌍 🌏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3346
std::strftime(mbstr, sizeof(mbstr), "%x", std::localtime(&t));and analyse its output.strftimeimplementation. It creates_LocaleUpdateobject. and passesnullptrto it._LocaleUpdateconstructor looks like that (pseudo-code)std::strftimeusesmdyfor "C" locale and we can do too. I found another places where we did a special case for "C" locale.STL/stl/src/xstrcoll.cpp
Lines 57 to 69 in 8b081e2
STL/stl/src/_tolower.cpp
Lines 52 to 58 in 8b081e2
STL/stl/src/_toupper.cpp
Lines 51 to 57 in 8b081e2