<format>: Make non-Standard constructors of basic_format_arg::handle and basic_format_context private#4489
Merged
StephanTLavavej merged 3 commits intomicrosoft:mainfrom Mar 19, 2024
Conversation
`basic_format_arg::handle` and `basic_format_context`
StephanTLavavej
approved these changes
Mar 18, 2024
Member
|
/azp run STL-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for improving |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes:
handle's constructor is exposition only and private in the standard wording ([format.arg]/10), so at least the constructor shouldn't be callable from user code. Removingstatic_assertmessages due to this.The standard wording seemingly leaves special member functions ofbasic_format_contextimplicitly declared ([format.context]), which means that its default constructor should be declared and defaulted.basic_format_contextare changed to take references to avoid double copy/move.basic_format_arg,handle, andbasic_format_contextare consistently performed by_Make_fromstatic member functions, and_Make_fromfunctions are consistently marked_NODISCARD.