Vectorize lexicographical_compare!#4552
Merged
StephanTLavavej merged 14 commits intomicrosoft:mainfrom Apr 12, 2024
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
lexicographical_compare!
StephanTLavavej
requested changes
Apr 7, 2024
AlexGuteniev
commented
Apr 8, 2024
tests/std/tests/GH_000431_lex_compare_memcmp_classify/test.compile.pass.cpp
Show resolved
Hide resolved
AlexGuteniev
commented
Apr 9, 2024
…thub.com/AlexGuteniev/STL into not_another_vector_algorithms_cpp_change
…algorithms_cpp_change # Conflicts: # stl/inc/xutility
tests/std/tests/GH_000431_lex_compare_memcmp_classify/test.compile.pass.cpp
Show resolved
Hide resolved
tests/std/tests/GH_000431_lex_compare_memcmp_classify/test.compile.pass.cpp
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Apr 12, 2024
Member
|
Thanks - this is so much easier to follow! 😻 🧠 |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for vectorizing one of the STL's most important algorithms! 😻 🚀 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3998
Using existing
mismatchvectorization and existing classifiers.Benchmark
Before:
After: