<expected>: Workaround for DevCom-10655311 "Class derived from std::expected can't be constructed with bool value type"#4664
Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom May 21, 2024
Conversation
6750910 to
ff047ff
Compare
ff047ff to
998478e
Compare
StephanTLavavej
approved these changes
May 15, 2024
Member
|
Thanks, looks perfect! Extra special thanks for the library-free repro that you posted on DevCom, which will really help the compiler team! 😻 |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for figuring out how to transcend the compiler's bug-limitations! 🐞 💥 😹 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works around DevCom-10655311. The reason of the issue seems to be that MSVC cannot recognize the injected-class-name as a template name in associated constraints in inherited constructors.
The workaround seemingly works with
/permissiveso there wouldn't be stealing conflicts with #4658, AFAIK.