Deduce the return type of queue::emplace and stack::emplace#4980
Merged
StephanTLavavej merged 2 commits intomicrosoft:mainfrom Sep 28, 2024
Merged
Conversation
CaseyCarter
approved these changes
Sep 24, 2024
Contributor
|
Woops 😊. Thanks again, RWC! |
Member
Author
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #4963. Fixes VSO-2261359 / AB#2261359 "[VCPKG] rocksdb installation failed with error C2440":
As the container adaptors are required to use
decltype(auto)in C++17, the "warning C5046: Symbol involving type with internal linkage not defined" in theconvertible_to_anyscenario and the ODR violation when mixing C++14 and C++17 TUs are unavoidable.In
<xmemory>, I'm lexicographically sorting_ADAPTOR_EMPLACE_RETURNbefore_CONTAINER_EMPLACE_RETURN, which will avoid an adjacent-add conflict with #4975 adding_LIST_REMOVE_RETURN(also in lex order).