requires for chrono::parse and comparison category detection#5044
Merged
StephanTLavavej merged 2 commits intomicrosoft:mainfrom Oct 30, 2024
Merged
requires for chrono::parse and comparison category detection#5044StephanTLavavej merged 2 commits intomicrosoft:mainfrom
requires for chrono::parse and comparison category detection#5044StephanTLavavej merged 2 commits intomicrosoft:mainfrom
Conversation
Drive-by: Simply `sub_match` by reusing `_Get_comparison_category_t`.
6709fb1 to
225c876
Compare
CaseyCarter
approved these changes
Oct 27, 2024
Contributor
CaseyCarter
left a comment
There was a problem hiding this comment.
One typo that I'll fix.
This comment was marked as resolved.
This comment was marked as resolved.
1 similar comment
Member
|
/azp run STL-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StephanTLavavej
approved these changes
Oct 29, 2024
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for finding even more SFINAE to eradicate! 🧹 🪄 ⚙️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #602.
Drive-by: Simply
sub_matchby reusing_Get_comparison_category_t.