<valarray>: Make valarray ADL-proof as required#5157
Merged
StephanTLavavej merged 2 commits intomicrosoft:mainfrom Dec 5, 2024
Merged
<valarray>: Make valarray ADL-proof as required#5157StephanTLavavej merged 2 commits intomicrosoft:mainfrom
<valarray>: Make valarray ADL-proof as required#5157StephanTLavavej merged 2 commits intomicrosoft:mainfrom
Conversation
Contributor
|
From the old pre-GitHub spreadsheet we used to track LWG issues, it looks like we miscategorized LWG-3133 as a pure wording change requiring no updates to product code. Nice catch. |
CaseyCarter
approved these changes
Nov 30, 2024
tests/std/tests/GH_000140_adl_proof_construction/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
Contributor
|
I pushed a commit to include |
StephanTLavavej
approved these changes
Dec 1, 2024
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for fixing our favoritest and bestest data structure! After |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #140 and #3100.
IMO it's quite insane to use an ADL-incompatible type with
valarray(or any numeric utility that expects overloaded operators). However, LWG-3133 relaxed the requirements for "numeric types" so much that ADL-bombs became acceptable. This PR also arguably implements LWG-3133 (by usingstd::addressofinstead ofoperator&).