Toolset update: VS 2022 17.14.5 Preview 1, WinSDK 26100#5580
Merged
StephanTLavavej merged 13 commits intomicrosoft:mainfrom Jun 14, 2025
Merged
Toolset update: VS 2022 17.14.5 Preview 1, WinSDK 26100#5580StephanTLavavej merged 13 commits intomicrosoft:mainfrom
StephanTLavavej merged 13 commits intomicrosoft:mainfrom
Conversation
…k assertion failed: rhs.is_lvalue() in constexpr.cpp, again".
…led: `p.edges.size() <= 1` comparing converted pointer in constant expression".
…n't accepted by the old lambda processor".
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
davidmrdavid
approved these changes
Jun 11, 2025
Member
davidmrdavid
left a comment
There was a problem hiding this comment.
Left a question, but otherwise LGTM.
@StephanTLavavej - lmk if you need help load balancing the creation of the compiler bugs and other bits you mentioned in the PR you did not have bandwidth for, I may be able to assist (/ I ought to be able, so this can be a forcing function :-P )
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Jun 14, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Changelog
💡 Notes
source_locationtests for upcoming EDG changes #5551. EDG's output for x86 was slightly different than what we expected, so I'm adjusting the test accordingly. Again, once this updated EDG ships, I'll be able to clean up the test to expect the new output only; right now it's accepting either new or old.basic_format_arg::handle's constructor (unrelated to the old lambda processor). Apparently we're storing a function pointer here for type erasure purposes (I don't really understand this myself, but we can't change the representation of this C++20 class now), but creating that function pointer with a lambda is not necessary. After looking at the lambda, I decided that I didn't like it, so I'm changing to a static member function template (which should be equally good for type erasure).__cdeclto avoid ODR violations, so that's another reason to use a function template.⚙️ Commits
p.edges.size() <= 1comparing converted pointer in constant expression".basic_format_arg::handle's constructor to a function template.