Skip to content

Fix to use test handler by stopping replace processing of existing index.js #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeviaVir merged 3 commits into from
May 19, 2017
Merged

Fix to use test handler by stopping replace processing of existing index.js #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1817738
Fix timeout to async test only
abetomo May 19, 2017
112682f
Add handler file used for testing of `bin/node-lambda`
abetomo May 19, 2017
f9b8f89
Fix to use test handler by stopping replace processing of existing in…
abetomo May 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions test/handler/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
'use strict';

exports.handler = (event, context, callback) => {
// It changes to a boolean value with `!!`
context.callbackWaitsForEmptyEventLoop =
!!event.callbackWaitsForEmptyEventLoop;

if (event.asyncTest)
setTimeout(() => console.log('sleep 3500 msec'), 3500);

eval(event.callbackCode);
};
109 changes: 66 additions & 43 deletions test/node-lambda.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@ const nodeLambdaPath = path.join(__dirname, '..', 'bin', 'node-lambda');
describe('bin/node-lambda', () => {
describe('node-lambda run', () => {
const _testMain = (expectedValues, done) => {
const run = spawn('node', [nodeLambdaPath, 'run', '--handler', '__test.handler']);
const run = spawn('node', [
nodeLambdaPath, 'run',
'--handler', '__test.handler',
'--eventFile', 'event.json',
]);
var stdoutString = '';
run.stdout.on('data', (data) => {
stdoutString += data.toString().replace(/\r|\n/g, '');
Expand All @@ -24,15 +28,14 @@ describe('bin/node-lambda', () => {
});
};

const _generateHandlerFile = (callbackString) => {
fs.writeFileSync(
'__test.js',
fs.readFileSync('index.js').toString()
.replace(/callback\(null\);/, callbackString)
);
const _generateEventFile = (eventObj) => {
fs.writeFileSync('event.json', JSON.stringify(eventObj));
};

before(() => execSync(`node ${nodeLambdaPath} setup`));
before(() => {
execSync(`node ${nodeLambdaPath} setup`);
fs.copy(path.join(__dirname, 'handler', 'index.js'), '__test.js');
});

after(() => {
[
Expand All @@ -45,69 +48,89 @@ describe('bin/node-lambda', () => {
].forEach((file) => fs.unlinkSync(file));
});

it('`node-lambda run` exitCode is `0` (callback(null))', (done) => {
_generateHandlerFile('callback(null);');
_testMain({ stdoutRegExp: /Success:$/, exitCode: 0 }, done);
});
describe('node-lambda run (Handler only sync processing)', () => {
const eventObj = {
asyncTest: false,
callbackWaitsForEmptyEventLoop: true // True is the default value of Lambda
};

it('`node-lambda run` exitCode is `0` (callback(null, "text"))', (done) => {
_generateHandlerFile('callback(null, "text");');
_testMain({ stdoutRegExp: /Success:"text"$/, exitCode: 0 }, done);
});
it('`node-lambda run` exitCode is `0` (callback(null))', (done) => {
_generateEventFile(Object.assign(eventObj, {
callbackCode: 'callback(null);'
}));
_testMain({ stdoutRegExp: /Success:$/, exitCode: 0 }, done);
});

it('`node-lambda run` exitCode is `255` (callback(new Error("e")))', (done) => {
_generateHandlerFile('callback(new Error("e"));');
_testMain({ stdoutRegExp: /Error: Error: e$/, exitCode: 255 }, done);
it('`node-lambda run` exitCode is `0` (callback(null, "text"))', (done) => {
_generateEventFile(Object.assign(eventObj, {
callbackCode: 'callback(null, "text");'
}));
_testMain({ stdoutRegExp: /Success:"text"$/, exitCode: 0 }, done);
});

it('`node-lambda run` exitCode is `255` (callback(new Error("e")))', (done) => {
_generateEventFile(Object.assign(eventObj, {
callbackCode: 'callback(new Error("e"));'
}));
_testMain({ stdoutRegExp: /Error: Error: e$/, exitCode: 255 }, done);
});
});

describe('node-lambda run (async)', function () {
this.timeout(5000); // give it time to setTimeout

const _generateHandlerFile = (callbackString, callbackWaitsForEmptyEventLoop) => {
const asyncCodeAndCallbackWaitsForEmptyEventLoopSettig = `
setTimeout(() => console.log('sleep 3500 msec'), 3500);
context.callbackWaitsForEmptyEventLoop = ${callbackWaitsForEmptyEventLoop};
`;
const testJsText = fs
.readFileSync('index.js').toString()
.replace(
/console.log\('Running index.handler'\);/,
asyncCodeAndCallbackWaitsForEmptyEventLoopSettig
)
.replace(/callback\(null\);/, callbackString);
fs.writeFileSync('__test.js', testJsText);
};
describe('node-lambda run (Handler includes async processing)', () => {
describe('callbackWaitsForEmptyEventLoop = true', function () {
this.timeout(5000); // give it time to setTimeout

const eventObj = {
asyncTest: true,
callbackWaitsForEmptyEventLoop: true
};

describe('callbackWaitsForEmptyEventLoop = true', () => {
it('`node-lambda run` exitCode is `0` (callback(null))', (done) => {
_generateHandlerFile('callback(null);', true);
_generateEventFile(Object.assign(eventObj, {
callbackCode: 'callback(null);',
}));
_testMain({ stdoutRegExp: /Success:sleep 3500 msec$/, exitCode: 0 }, done);
});

it('`node-lambda run` exitCode is `0` (callback(null, "text"))', (done) => {
_generateHandlerFile('callback(null, "text");', true);
_generateEventFile(Object.assign(eventObj, {
callbackCode: 'callback(null, "text");',
}));
_testMain({ stdoutRegExp: /Success:"text"sleep 3500 msec$/, exitCode: 0 }, done);
});

it('`node-lambda run` exitCode is `255` (callback(new Error("e")))', (done) => {
_generateHandlerFile('callback(new Error("e"));', true);
_generateEventFile(Object.assign(eventObj, {
callbackCode: 'callback(new Error("e"));',
}));
_testMain({ stdoutRegExp: /Error: Error: esleep 3500 msec$/, exitCode: 255 }, done);
});
});

describe('callbackWaitsForEmptyEventLoop = false', () => {
const eventObj = {
asyncTest: true,
callbackWaitsForEmptyEventLoop: false
};

it('`node-lambda run` exitCode is `0` (callback(null))', (done) => {
_generateHandlerFile('callback(null);', false);
_generateEventFile(Object.assign(eventObj, {
callbackCode: 'callback(null);',
}));
_testMain({ stdoutRegExp: /Success:$/, exitCode: 0 }, done);
});

it('`node-lambda run` exitCode is `0` (callback(null, "text"))', (done) => {
_generateHandlerFile('callback(null, "text");', false);
_generateEventFile(Object.assign(eventObj, {
callbackCode: 'callback(null, "text");',
}));
_testMain({ stdoutRegExp: /Success:"text"$/, exitCode: 0 }, done);
});

it('`node-lambda run` exitCode is `255` (callback(new Error("e")))', (done) => {
_generateHandlerFile('callback(new Error("e"));', false);
_generateEventFile(Object.assign(eventObj, {
callbackCode: 'callback(new Error("e"));',
}));
_testMain({ stdoutRegExp: /Error: Error: e$/, exitCode: 255 }, done);
});
});
Expand Down