Skip to content

fixed getValLength for null values; this fixes #151; also added a tes… #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erdii merged 1 commit into from
Oct 31, 2019
Merged

fixed getValLength for null values; this fixes #151; also added a tes… #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _src/lib/node_cache.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,7 +593,7 @@ module.exports = class NodeCache extends EventEmitter
# if the data is a Promise, use defined default
# (can't calculate actual/resolved value size synchronously)
@options.promiseValueSize
else if typeof value is "object"
else if value? and typeof value is "object"
# if the data is an Object multiply each element with a defined default length
@options.objectValueSize * Object.keys( value ).length
else if typeof value is "boolean"
Expand Down
20 changes: 20 additions & 0 deletions _src/test/mocha_test.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1143,4 +1143,24 @@ describe "`#{pkg.name}@#{pkg.version}` on `node@#{process.version}`", () ->

return

describe "Issues", () ->
describe("#151 - cannot set null", () ->
cache = null
before(() ->
cache = new nodeCache()
return
)

it("set the value `null` - this should not throw or otherwise fail", () ->
cache.set("test", null)
return
)

it("should also return `null`", () ->
should(cache.get("test")).be.null()
return
)
return
)
return
return