Skip to content

Comments

Revert "(get) return undefined when key is expired"#156

Merged
erdii merged 1 commit intomasterfrom
hotfix/154_restore_deleteOnExpire
Nov 17, 2019
Merged

Revert "(get) return undefined when key is expired"#156
erdii merged 1 commit intomasterfrom
hotfix/154_restore_deleteOnExpire

Conversation

@erdii
Copy link
Member

@erdii erdii commented Nov 16, 2019

This reverts commit dcb3a19.
This fixes #154.

@erdii erdii self-assigned this Nov 16, 2019
@erdii erdii requested a review from daluf November 16, 2019 17:42
@erdii
Copy link
Member Author

erdii commented Nov 17, 2019

I did not add a regression test for this issue, because the bug already had a test which was, unfortunately, changed along the introduction of the bug.

@erdii erdii merged commit b0aa682 into master Nov 17, 2019
@erdii erdii deleted the hotfix/154_restore_deleteOnExpire branch November 17, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deleteOnExpire: false appears to be ignored in version 5

1 participant