take() method added for single-read values#160
Merged
erdii merged 3 commits intonode-cache:masterfrom Dec 4, 2019
Merged
Conversation
Closed
erdii
requested changes
Dec 3, 2019
erdii
reviewed
Dec 4, 2019
Member
erdii
left a comment
There was a problem hiding this comment.
nice! even with tests for the bug <3
erdii
approved these changes
Dec 4, 2019
Member
|
thank you! i will provide an update on the weekend |
erdii
added a commit
that referenced
this pull request
Dec 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #159
Single-use tokens (such as OTPs) cannot be used under two circumstances:
TTL solves the first problem. This
takemethod aims to solve the second problem. The value could be active (TTL not expired), but if it is already "touched" (get() called for verification), then just delete it, so that no replay attack is possible.