stream: return undefined writable/readable#40803
Closed
ronag wants to merge 1 commit intonodejs:mainfrom
Closed
Conversation
Return undefined for writable/readable props if the stream never was writable/readable. This way we can differentiate between Duplex streams that never was writable/readable and Duplex streams which has finished writing/reading.
Member
Author
|
@nodejs/streams |
Member
|
I think this needs docs changes (prose + |
jasnell
approved these changes
Nov 13, 2021
JungMinu
approved these changes
Nov 18, 2021
Member
Author
Collaborator
This was referenced Nov 19, 2021
Contributor
|
It looks like there are related CI failures. |
Contributor
|
There are a few CI failures that would need to be addressed in order to land this. |
Member
|
I think this would need to be documented. |
Member
|
@ronag can you rebase? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return undefined for writable/readable props if the stream
never was writable/readable. This way we can differentiate between
Duplex streams that never was writable/readable and Duplex streams
which has finished writing/reading.