Skip to content

fs: add recursive watch for linux#45098

Merged
nodejs-github-bot merged 38 commits intonodejs:mainfrom
anonrig:fs/add-recursive-watch
Oct 31, 2022
Merged

fs: add recursive watch for linux#45098
nodejs-github-bot merged 38 commits intonodejs:mainfrom
anonrig:fs/add-recursive-watch

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented Oct 20, 2022 •
edited
Loading

Fixes #36005

List

CC @nodejs/fs

@anonrig anonrig added fs Issues and PRs related to the fs subsystem / file system. notable-change PRs with changes that should be highlighted in changelogs. labels Oct 20, 2022
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 20, 2022
kibertoad
kibertoad reviewed Oct 20, 2022
View reviewed changes
aduh95
aduh95 reviewed Oct 20, 2022
View reviewed changes
aduh95
aduh95 reviewed Oct 20, 2022
View reviewed changes
bnoordhuis
bnoordhuis reviewed Oct 20, 2022
View reviewed changes
cjihrig
cjihrig reviewed Oct 20, 2022
View reviewed changes
@anonrig anonrig force-pushed the fs/add-recursive-watch branch from 0c106f0 to 45e8f37 Compare October 21, 2022 18:17
@anonrig anonrig force-pushed the fs/add-recursive-watch branch 6 times, most recently from 7275124 to a7b310d Compare October 21, 2022 23:24
@anonrig anonrig marked this pull request as ready for review October 21, 2022 23:30
@anonrig anonrig force-pushed the fs/add-recursive-watch branch from a7b310d to fd0a954 Compare October 21, 2022 23:46
@anonrig anonrig requested review from targos and removed request for kibertoad October 21, 2022 23:46
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
aduh95
aduh95 reviewed Oct 22, 2022
View reviewed changes
mcollina
mcollina requested changes Oct 22, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module uses a mix of callbacks and promises. I would prefer if it only relied on callbacks as it would be a callback API. Maybe I'm a bit too concerned about the intertwining of our two sets of APIs.

This also needs support for the promises API.

aduh95
aduh95 reviewed Oct 22, 2022
View reviewed changes
@anonrig anonrig force-pushed the fs/add-recursive-watch branch from d0f5179 to df1c187 Compare October 22, 2022 21:07
jasnell
jasnell reviewed Oct 31, 2022
View reviewed changes
jasnell
jasnell reviewed Oct 31, 2022
View reviewed changes
@targos targos removed their request for review October 31, 2022 15:13
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 31, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47596/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 31, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47603/

@anonrig anonrig added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Oct 31, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 31, 2022

Landed in 17ae2ab

@github-actions github-actions bot mentioned this pull request Nov 1, 2022
Open
17 tasks
@MoLow
Copy link
Member

MoLow commented Nov 1, 2022

@anonrig congratulations 🎉

@anonrig anonrig mentioned this pull request Nov 1, 2022
Merged
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
@MoLow MoLow mentioned this pull request Nov 1, 2022
Closed
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
@danielleadams
Copy link
Contributor

danielleadams commented Dec 30, 2022

Hi @anonrig - this did not land cleanly on v18.x. When landing there were variables used that were not defined in v18.x-staging branch's version of the file. Could you open a backport PR? Thank you.

@anonrig
Copy link
Member Author

anonrig commented Jan 3, 2023

@danielleadams It seems this pull request is in the v18.x-staging branch: https://github.com/nodejs/node/blob/v18.13.0-proposal/lib/internal/fs/recursive_watch.js

@torchiaf torchiaf mentioned this pull request Jan 12, 2023
Closed
@juanarbol
Copy link
Member

juanarbol commented Jan 26, 2023

@danielleadams It seems this pull request is in the v18.x-staging branch: https://github.com/nodejs/node/blob/v18.13.0-proposal/lib/internal/fs/recursive_watch.js

That link is a 404; marking this is a "backport-requested-v18.x" again.

@anonrig
Copy link
Member Author

anonrig commented Jan 26, 2023

This pull request is already backported @juanarbol

Referencing: https://github.com/nodejs/node/blob/v18.x-staging/lib/internal/fs/recursive_watch.js

@aduh95
Copy link
Contributor

aduh95 commented Jan 27, 2023

That's not correct @anonrig, the pull request was not backported, it never showed on the v18.x changelog. The file you linked was added with c2f0377 (which is a backport for #45265), but all the other changes in this PR still need to be backported manually (docs and tests).

@nascarsayan nascarsayan mentioned this pull request Mar 12, 2023
Closed
@schlichtanders schlichtanders mentioned this pull request Oct 9, 2023
Closed
@raphaelboukara
Copy link

raphaelboukara commented Jan 15, 2024

Hi :)
Does this fix will be backported to v18.x ?

@mcollina
Copy link
Member

mcollina commented Jan 15, 2024 •
edited
Loading

I don't expect this to be backported, because there are issues with this and Node.js v18 is in maintenance.

See #48437 for more details.

@arenekosreal arenekosreal mentioned this pull request Feb 18, 2024
Closed
@kirjavascript kirjavascript mentioned this pull request Apr 18, 2024
Merged
@avivkeller avivkeller mentioned this pull request Oct 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@targos targos targos left review comments

@aduh95 aduh95 aduh95 approved these changes

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@MoLow MoLow MoLow approved these changes

@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis

@cjihrig cjihrig Awaiting requested review from cjihrig

@richardlau richardlau Awaiting requested review from richardlau

+3 more reviewers

@kibertoad kibertoad kibertoad left review comments

@cagataycali cagataycali cagataycali left review comments

@V-for-Vasili V-for-Vasili V-for-Vasili left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Recursive fs.watch for linux