ProxySite

src: disable concurrent sparkplug compilation#47450

Closed

targos wants to merge 1 commit intonodejs:mainfrom

targos:no-concurrent-sparkplug

Member

targos commented Apr 6, 2023

It introduces process hangs on some platforms because Node.js doesn't tear down V8 correctly.
Disable it while we work on a solution.

Refs: #47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902

targos added dont-land-on-v14.x labels

Collaborator

nodejs-github-bot commented Apr 6, 2023

Review requested:

@nodejs/startup

targos added the request-ci label

nodejs-github-bot added c++ needs-ci labels

This was referenced Apr 6, 2023

test: mark test/parallel/test-file-write-stream4 as flaky #47423

Merged

test: mark test-http2-large-file flaky on aix #47410

Closed

richardlau approved these changes

View reviewed changes

anonrig approved these changes

View reviewed changes

github-actions bot removed the request-ci label

Member Author

targos commented Apr 6, 2023

Just added reverts of earlier test skips to make sure this actually works.

targos added the request-ci label

github-actions bot removed the request-ci label

Collaborator

nodejs-github-bot commented Apr 6, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51007/

dinfuehr mentioned this pull request

Do not drain worker tasks on main thread #47452

Open

Member Author

targos commented Apr 6, 2023

Failed parallel.test-wasm-web-api 😭

Member Author

targos commented Apr 6, 2023

The problem is I don't know if the fix doesn't work or if it's too late to set the flag. I'll debug when I have some time

richardlau mentioned this pull request

stream: bump default highWaterMark #46608

Closed

mhdawson approved these changes

View reviewed changes

Member

mhdawson left a comment

LGTM

Contributor

miladfarca commented Apr 6, 2023

The following three patches could potentially fix the timeout, please consider testing before disabling concurrent SP:

https://chromium-review.googlesource.com/c/v8/v8/+/4403395
https://chromium-review.googlesource.com/c/v8/v8/+/4405689
#47452

targos force-pushed the no-concurrent-sparkplug branch from aecc5af to e13207f Compare

April 7, 2023 07:39

targos mentioned this pull request

Fix concurrent sparkplug #47461

Closed

targos added the request-ci label

github-actions bot removed the request-ci label

Collaborator

nodejs-github-bot commented Apr 7, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51039/

Collaborator

nodejs-github-bot commented Apr 7, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51044/

Collaborator

nodejs-github-bot commented Apr 7, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51049/

targos added a commit to targos/node that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

dff4e7c

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

6f6cb4e

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: #47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: #47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit to targos/node that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

f9ef08f

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

109c1f4

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs/node#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs/node#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

805ad51

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs/node#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs/node#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit to targos/node that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

68314e3

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

2419ce2

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs/node#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs/node#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

1f73c3d

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs/node#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs/node#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

a325f2f

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs/node#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs/node#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

23f89dc

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs/node#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs/node#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

e7cec22

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs/node#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs/node#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

167587f

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs/node#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs/node#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit to targos/node that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

44e5ac1

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

c6740fb

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs/node#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs/node#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

56cfc00

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs/node#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs/node#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

4bbb81f

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs/node#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs/node#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

0fb711e

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs/node#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs/node#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

d11c61b

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: #47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: #47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

f614946

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs/node#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs/node#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit to targos/node that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

0d6ccc7

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

25277c2

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs/node#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs/node#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

e972211

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs/node#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs/node#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

83bee68

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: #47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: #47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

558dab6

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs/node#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs/node#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

a7ef78b

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs/node#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs/node#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

015e5ea

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs/node#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs/node#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: disable V8 concurrent sparkplug compilation

cce274e

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs/node#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs/node#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos mentioned this pull request

flaky: parallel/test-http2-large-write-multiple-requests #52550

Closed

nodejs-github-bot mentioned this pull request

deps: update V8 to 13.0 #55014

Closed

targos mentioned this pull request

deps: update V8 to 13.6 #58070

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ needs-ci v8 engine