report: add `--report-exclude-network` option by Ethan-Arrowood · Pull Request #51645 · nodejs/node

Ethan-Arrowood · 2024-02-02T03:17:12Z

New option --report-exclude-network, also available as report.excludeNetwork, enables the user to exclude networking interfaces in their diagnostic report. On some systems, this can cause the report to take minutes to generate so this option can be used to optimize that.

Fixes: #46060

Ethan-Arrowood · 2024-02-02T03:22:47Z

I'm not used to the tests not being in either sequential or parallel. I add some more tests that verify the header.networkInterfaces is missing when this option is set (either by CLI or configuration). I used new test syntax and what not so hopefully that still works in the test/report/ directory.

src/node_options.h

src/node_report_module.cc

test/report/test-report-disable-network.js

doc/api/report.md

lib/internal/process/report.js

src/node_report.cc

test/report/test-report-config.js

Adds a new option `process.report.networkDisabled` and cli option `--report-network-disabled` which will disable any netowkring operations for the `report` generation. Fixes: nodejs#46060 PR-URL: nodejs#51645

github-actions · 2024-02-05T23:12:54Z

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @anonrig.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

Ethan-Arrowood · 2024-02-05T23:13:24Z

@anonrig I'm getting a segmentation fault now (after I made the change Joyee recommended). Trying to debug but this is hard

src/node_report_module.cc

doc/api/report.md

nodejs-github-bot · 2024-02-15T23:47:35Z

Commit Queue failed

- Loading data for nodejs/node/pull/51645
✔  Done loading data for nodejs/node/pull/51645
----------------------------------- PR info ------------------------------------
Title      report: add `--report-exclude-network` option (#51645)
Author     Ethan Arrowood  (@Ethan-Arrowood)
Branch     Ethan-Arrowood:fix/process-getreport -> nodejs:main
Labels     c++, semver-minor, lib / src, notable-change, needs-ci, report
Commits    1
 - report: add `--report-exclude-network` option
Committers 1
 - Ethan Arrowood 
PR-URL: https://github.com/nodejs/node/pull/51645
Fixes: https://github.com/nodejs/node/issues/46060
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Joyee Cheung 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51645
Fixes: https://github.com/nodejs/node/issues/46060
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Joyee Cheung 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - report: add `--report-exclude-network` option
   ℹ  This PR was created on Fri, 02 Feb 2024 03:17:12 GMT
   ✔  Approvals: 2
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/51645#pullrequestreview-1864004600
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/51645#pullrequestreview-1881176781
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2024-02-15T15:18:08Z: https://ci.nodejs.org/job/node-test-pull-request/57100/
- Querying data for job/node-test-pull-request/57100/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/7923747889

nodejs-github-bot · 2024-02-16T01:14:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57119/

nodejs-github-bot · 2024-02-16T13:15:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57136/

nodejs-github-bot · 2024-02-17T01:38:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57154/

nodejs-github-bot · 2024-02-17T03:36:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57155/

New option `--report-exclude-network`, also available as `report.excludeNetwork`, enables the user to exclude networking interfaces in their diagnostic report. On some systems, this can cause the report to take minutes to generate so this option can be used to optimize that. Fixes: nodejs#46060 PR-URL: nodejs#51645 Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>

nodejs-github-bot · 2024-02-21T17:28:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57259/

nodejs-github-bot · 2024-02-23T13:14:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57345/

nodejs-github-bot · 2024-02-27T10:46:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57456/

nodejs-github-bot · 2024-02-29T16:38:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57507/

Ethan-Arrowood · 2024-03-01T16:23:41Z

If you like at all of the CI runs for this PR it has only failed flaky tests. There is nothing failing consistently, so I believe this is safe to land

nodejs-github-bot · 2024-03-01T16:27:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57536/

nodejs-github-bot · 2024-03-01T17:35:13Z

Commit Queue failed

- Loading data for nodejs/node/pull/51645
✔  Done loading data for nodejs/node/pull/51645
----------------------------------- PR info ------------------------------------
Title      report: add `--report-exclude-network` option (#51645)
Author     Ethan Arrowood  (@Ethan-Arrowood)
Branch     Ethan-Arrowood:fix/process-getreport -> nodejs:main
Labels     c++, semver-minor, lib / src, notable-change, needs-ci, report
Commits    1
 - report: add `--report-exclude-network` option
Committers 1
 - Ethan Arrowood 
PR-URL: https://github.com/nodejs/node/pull/51645
Fixes: https://github.com/nodejs/node/issues/46060
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Joyee Cheung 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51645
Fixes: https://github.com/nodejs/node/issues/46060
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Joyee Cheung 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - report: add `--report-exclude-network` option
   ℹ  This PR was created on Fri, 02 Feb 2024 03:17:12 GMT
   ✔  Approvals: 2
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/51645#pullrequestreview-1864004600
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/51645#pullrequestreview-1881176781
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-03-01T16:27:31Z: https://ci.nodejs.org/job/node-test-pull-request/57536/
- Querying data for job/node-test-pull-request/57536/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/8114994573

Ethan-Arrowood · 2024-03-01T17:36:32Z

Commit-queue failed because I pushed a rebase after latest reviews. Can someone reapprove this please? @anonrig @joyeecheung

nodejs-github-bot · 2024-03-01T21:50:06Z

Landed in 009665f

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Feb 2, 2024

Ethan-Arrowood requested a review from joyeecheung February 2, 2024 03:17

Ethan-Arrowood force-pushed the fix/process-getreport branch from 8b03a57 to 0f094cb Compare February 2, 2024 03:21

Ethan-Arrowood marked this pull request as ready for review February 2, 2024 03:21

anonrig self-requested a review February 2, 2024 03:39

Ethan-Arrowood force-pushed the fix/process-getreport branch 2 times, most recently from 8341898 to 1f12672 Compare February 2, 2024 04:18

Ethan-Arrowood added the report Issues and PRs related to process.report. label Feb 2, 2024

joyeecheung reviewed Feb 2, 2024

View reviewed changes

src/node_options.h Outdated Show resolved Hide resolved

src/node_report_module.cc Outdated Show resolved Hide resolved

styfle reviewed Feb 2, 2024

View reviewed changes

test/report/test-report-disable-network.js Show resolved Hide resolved

anonrig reviewed Feb 2, 2024

View reviewed changes

Ethan-Arrowood changed the title ~~report: add --report-disable-network option~~ report: add --report-network-disabled option Feb 5, 2024

Ethan-Arrowood requested review from anonrig, joyeecheung and styfle February 5, 2024 18:29

Ethan-Arrowood force-pushed the fix/process-getreport branch from 43125e2 to 2d5fb4e Compare February 5, 2024 20:21

Ethan-Arrowood force-pushed the fix/process-getreport branch from 2d5fb4e to 25be48a Compare February 5, 2024 20:28

Ethan-Arrowood force-pushed the fix/process-getreport branch from 0ca3be5 to e485abb Compare February 5, 2024 20:36

anonrig approved these changes Feb 5, 2024

View reviewed changes

anonrig added semver-minor PRs that contain new features and should be released in the next minor version. notable-change PRs with changes that should be highlighted in changelogs. labels Feb 5, 2024

Ethan-Arrowood commented Feb 6, 2024

View reviewed changes

src/node_report_module.cc Outdated Show resolved Hide resolved

richardlau reviewed Feb 6, 2024

View reviewed changes

doc/api/report.md Outdated Show resolved Hide resolved

Ethan-Arrowood added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 15, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 15, 2024

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Feb 15, 2024

Ethan-Arrowood force-pushed the fix/process-getreport branch from 99d022c to 67ca735 Compare February 21, 2024 17:13

Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2024

Ethan-Arrowood mentioned this pull request Feb 22, 2024

CI flakiness becomes unmanageable #51819

Closed

Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2024

joyeecheung removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Feb 27, 2024

joyeecheung approved these changes Mar 1, 2024

View reviewed changes

styfle mentioned this pull request Mar 1, 2024

fix: improve performance of getReport() lovell/detect-libc#21

Merged

dstaley mentioned this pull request Mar 18, 2024

[BUG] process.report.getReport() is very very slow on win32 npm/npm-install-checks#95

Closed

1 task

RafaelGSS mentioned this pull request Apr 15, 2024

2024-04-24, Version 22.0.0 (Current) #52505

Merged

marco-ippolito mentioned this pull request May 2, 2024

v20.13.0 proposal #52793

Merged

Uh oh!

Conversation

Ethan-Arrowood commented Feb 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ethan-Arrowood commented Feb 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 5, 2024

Uh oh!

Ethan-Arrowood commented Feb 5, 2024

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Feb 15, 2024

Uh oh!

nodejs-github-bot commented Feb 16, 2024

Uh oh!

nodejs-github-bot commented Feb 16, 2024

Uh oh!

nodejs-github-bot commented Feb 17, 2024

Uh oh!

nodejs-github-bot commented Feb 17, 2024

Uh oh!

nodejs-github-bot commented Feb 21, 2024

Uh oh!

nodejs-github-bot commented Feb 23, 2024

Uh oh!

nodejs-github-bot commented Feb 27, 2024

Uh oh!

nodejs-github-bot commented Feb 29, 2024

Uh oh!

Ethan-Arrowood commented Mar 1, 2024

Uh oh!

nodejs-github-bot commented Mar 1, 2024

Uh oh!

nodejs-github-bot commented Mar 1, 2024

Uh oh!

Ethan-Arrowood commented Mar 1, 2024

Uh oh!

nodejs-github-bot commented Mar 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Ethan-Arrowood commented Feb 2, 2024 •

edited

Loading

Ethan-Arrowood commented Feb 2, 2024 •

edited

Loading