build,win: fix problems with format-md#52161
Closed
huseyinacacak-janea wants to merge 2 commits intonodejs:mainfrom
Closed
build,win: fix problems with format-md#52161huseyinacacak-janea wants to merge 2 commits intonodejs:mainfrom
huseyinacacak-janea wants to merge 2 commits intonodejs:mainfrom
Conversation
f94706f to
5a6fea5
Compare
Contributor
Author
|
Initially, this PR failed because it converted the line breaks of all |
Contributor
|
I've let this run through the node-test-linter in CI to ensure it's good. The run passed. |
Contributor
Author
|
It's ready for review. |
Collaborator
Collaborator
Collaborator
Contributor
Author
|
I see CI has passed. Is there something else I can help with this to move forward? |
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/52161 ✔ Done loading data for nodejs/node/pull/52161 ----------------------------------- PR info ------------------------------------ Title build,win: fix problems with format-md (#52161) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch huseyinacacak-janea:huseyin-12044-fix-issues-in-linter-and-tests-on-windows -> nodejs:main Labels windows, build, meta, needs-ci, commit-queue-rebase Commits 2 - doc: add .gitattributes for md files - build,win: fix problems with format-md Committers 1 - Hüseyin Açacak PR-URL: https://github.com/nodejs/node/pull/52161 Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52161 Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 20 Mar 2024 09:29:58 GMT ✔ Approvals: 1 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/52161#pullrequestreview-1970052472 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2024-04-17T08:46:58Z: https://ci.nodejs.org/job/node-test-pull-request/58454/ - Querying data for job/node-test-pull-request/58454/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8784247836 |
MoLow
approved these changes
Apr 24, 2024
MoLow
pushed a commit
that referenced
this pull request
Apr 24, 2024
PR-URL: #52161 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
|
Landed in bed1fa9 |
aduh95
pushed a commit
that referenced
this pull request
Apr 29, 2024
PR-URL: #52161 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Apr 29, 2024
PR-URL: #52161 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#52161 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The command
vcbuild lintwas experiencing failures on Windows. The appropriate fix would have been to executevcbuild format-md, but despite its availability, it wasn't possible to execute it. This PR enablesvcbuild format-mdto be executed. Furthermore, a validation has been incorporated into.gitattributesto verify that.mdfiles utilize LF as their line endings.