Abolished github.com/pkg/errors#420
Merged
deepmap-marcinr merged 3 commits intooapi-codegen:masterfrom Aug 23, 2021
Merged
Conversation
Contributor
Author
|
Fixed test at #410 |
ckarenz
reviewed
Aug 14, 2021
| object[fieldName], err = json.Marshal(field) | ||
| if err != nil { | ||
| return nil, errors.Wrap(err, fmt.Sprintf("error marshaling '%s'", fieldName)) | ||
| return nil, fmt.Errorf("error marshaling '%s'", fieldName) |
There was a problem hiding this comment.
Throughout this change, you're losing the wrapped error. This would be equivalent to the old error:
Suggested change
| return nil, fmt.Errorf("error marshaling '%s'", fieldName) | |
| return nil, fmt.Errorf("error marshaling '%s': %w", fieldName, err) |
|
I might also recommend converting |
Contributor
Author
resolved format. |
Contributor
Author
Yes, Not supported here. |
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
* remove github.com/pkg/errors * `go mod tidy` * fix losted err wrap
adrianpk
added a commit
to foorester/oapi-codegen
that referenced
this pull request
May 31, 2024
* remove github.com/pkg/errors * `go mod tidy` * fix losted err wrap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #418
To move
github.com/pkg/errorstoerros.