Pass the OCM connection to GetTrustedIPs.#678
Pass the OCM connection to GetTrustedIPs.#678openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
0bee118 to
8d8ca1a
Compare
|
/lgtm |
This is inline with other methods taking it as an argument, and prevents breaking CAD that is building it's own OCM connection.
8d8ca1a to
d1e607a
Compare
|
/lgtm |
|
@bergmannf: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #678 +/- ##
==========================================
+ Coverage 50.92% 50.95% +0.03%
==========================================
Files 76 76
Lines 5760 5756 -4
==========================================
Hits 2933 2933
+ Misses 2424 2420 -4
Partials 403 403
🚀 New features to boost your workflow:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bergmannf, Nikokolas3270, typeid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is inline with other methods taking it as an argument, and prevents breaking CAD that is building it's own OCM connection.
What type of PR is this?
What this PR does / Why we need it?
CAD as a client build it's own OCM connection that is passed in and must be used - creating a new OCM connection breaks access to OCM.
Which Jira/Github issue(s) does this PR fix?
Special notes for your reviewer
Unit Test Coverage
Guidelines
Test coverage checks
Pre-checks (if applicable)