Maint: add comments to clarify the filtering of trusted ips#686
Maint: add comments to clarify the filtering of trusted ips#686openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
|
@typeid: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #686 +/- ##
=======================================
Coverage 50.95% 50.95%
=======================================
Files 76 76
Lines 5764 5764
=======================================
Hits 2937 2937
Misses 2422 2422
Partials 405 405
🚀 New features to boost your workflow:
|
joshbranham
left a comment
There was a problem hiding this comment.
Thanks for clarifying this for future us
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joshbranham, typeid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / Why we need it?
This PR adds comments around the "why" we filter the trusted ip list.
Which Jira/Github issue(s) does this PR fix?
Special notes for your reviewer
Unit Test Coverage
Guidelines
Test coverage checks
Pre-checks (if applicable)