Skip to content

Don't log INFO when retrieving backplane URL from config#824

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
joshbranham:tweak-log-level
Nov 5, 2025
Merged

Don't log INFO when retrieving backplane URL from config#824
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
joshbranham:tweak-log-level

Conversation

@joshbranham
Copy link
Contributor

@joshbranham joshbranham commented Nov 5, 2025 •
edited
Loading

What type of PR is this?

  • fix (Bug Fix)
  • feat (New Feature)
  • docs (Documentation)
  • test (Test Coverage)
  • chore (Clean Up / Maintenance Tasks)
  • other (Anything that doesn't fit the above)

What this PR does / Why we need it?

Increase the log level of Backplane URL retrieved via OCM environment: $url to debug to reduce output for callers.

Which Jira/Github issue(s) does this PR fix?

  • Related Issue #
  • Closes #

Special notes for your reviewer

Sample of this in osdctl:

❯ ./dist/osdctl_darwin_arm64_v8.0/osdctl cluster reports -S list --cluster-id 2mbuoph6iv2qh2tqes1eadppvg9fgd0l
INFO[0000] Backplane URL retrieved via OCM environment: https://api.backplane.openshift.com <<<<<<<<
INFO[0001] Backplane URL retrieved via OCM environment: https://api.backplane.openshift.com <<<<<<<<
Found 2 reports for cluster 2mbuoph6iv2qh2tqes1eadppvg9fgd0l

Report ID                     Summary                                                                  Created At
351Xnk77VJxLmzzAo09p486sYHe   test123                                                                  2025-11-04T17:52:00Z
351Xrc4FHx7e7bCA5Mcnb4620vB   this is a really long summary so I Am just testing how word wrap works   2025-11-04T17:52:30Z

Unit Test Coverage

Guidelines

  • If it's a new sub-command or new function to an existing sub-command, please cover at least 50% of the code
  • If it's a bug fix for an existing sub-command, please cover 70% of the code

Test coverage checks

  • Added unit tests
  • Created jira card to add unit test
  • This PR may not need unit tests

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR
  • Backward compatible

/label tide/merge-method-squash

@joshbranham joshbranham self-assigned this Nov 5, 2025
@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 5, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2025

@joshbranham: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 52.85%. Comparing base (1734520) to head (5a4bf40).

Files with missing lines Patch % Lines
pkg/cli/config/config.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #824   +/-   ##
=======================================
  Coverage   52.85%   52.85%           
=======================================
  Files          86       86           
  Lines        6421     6421           
=======================================
  Hits         3394     3394           
  Misses       2576     2576           
  Partials      451      451
Files with missing lines Coverage Δ
pkg/cli/config/config.go 75.50% <50.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MitaliBhalla
Copy link
Contributor

MitaliBhalla commented Nov 5, 2025

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joshbranham, MitaliBhalla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 796418a into openshift:main Nov 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarthall smarthall Awaiting requested review from smarthall

1 more reviewer

@MitaliBhalla MitaliBhalla MitaliBhalla approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@joshbranham joshbranham

@MitaliBhalla MitaliBhalla

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshbranham @codecov-commenter @MitaliBhalla