Skip to content

SREP-2525 fix error handling when a managed-job does not return a 200#841

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
dakotalongRH:segvfix
Nov 19, 2025
Merged

SREP-2525 fix error handling when a managed-job does not return a 200#841
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
dakotalongRH:segvfix

Conversation

@dakotalongRH
Copy link
Contributor

@dakotalongRH dakotalongRH commented Nov 17, 2025

Fix error handling when a managed-job fails to return a 200
https://issues.redhat.com/browse/SREP-2525

What type of PR is this?

  • fix (Bug Fix)
  • feat (New Feature)
  • docs (Documentation)
  • test (Test Coverage)
  • chore (Clean Up / Maintenance Tasks)
  • other (Anything that doesn't fit the above)

What this PR does / Why we need it?

https://issues.redhat.com/browse/SREP-2525

Which Jira/Github issue(s) does this PR fix?

https://issues.redhat.com/browse/SREP-2525

  • Related Issue #
  • Closes #

Special notes for your reviewer

Unit Test Coverage

Guidelines

  • If it's a new sub-command or new function to an existing sub-command, please cover at least 50% of the code
  • If it's a bug fix for an existing sub-command, please cover 70% of the code

Test coverage checks

  • Added unit tests
  • Created jira card to add unit test
  • This PR may not need unit tests

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR
  • Backward compatible

/label tide/merge-method-squash

https://issues.redhat.com/browse/SREP-2525
dc9900a 
Fix error handling when a managed-job fails to return a 200
@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 17, 2025
@openshift-ci openshift-ci bot requested review from Tafhim and typeid November 17, 2025 19:11
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.92%. Comparing base (15030a6) to head (bcdd982).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
cmd/ocm-backplane/managedJob/createManagedJob.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #841      +/-   ##
==========================================
- Coverage   52.94%   52.92%   -0.02%     
==========================================
  Files          86       86              
  Lines        6501     6507       +6     
==========================================
+ Hits         3442     3444       +2     
- Misses       2600     2602       +2     
- Partials      459      461       +2
Files with missing lines Coverage Δ
cmd/ocm-backplane/managedJob/createManagedJob.go 67.45% <71.42%> (-0.03%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AlexSmithGH
Copy link

AlexSmithGH commented Nov 17, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2025
@samanthajayasinghe
Copy link
Contributor

samanthajayasinghe commented Nov 19, 2025

/lgtm
/approve

@samanthajayasinghe
Copy link
Contributor

samanthajayasinghe commented Nov 19, 2025

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexSmithGH, dakotalongRH, samanthajayasinghe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2025

@dakotalongRH: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d90ba3a into openshift:main Nov 19, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tafhim Tafhim Awaiting requested review from Tafhim

@typeid typeid Awaiting requested review from typeid

Assignees

@samanthajayasinghe samanthajayasinghe

@AlexSmithGH AlexSmithGH

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dakotalongRH @codecov-commenter @AlexSmithGH @samanthajayasinghe