Skip to content

SREP-1739 fix : Add 182 prefix proxy IP to the allowlist in the AWS session policy #858

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
samanthajayasinghe:add-182-1p
Dec 3, 2025
Merged

SREP-1739 fix : Add 182 prefix proxy IP to the allowlist in the AWS session policy #858
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
samanthajayasinghe:add-182-1p

Conversation

@samanthajayasinghe
Copy link
Contributor

@samanthajayasinghe samanthajayasinghe commented Dec 2, 2025

What type of PR is this?

  • fix (Bug Fix)
  • feat (New Feature)
  • docs (Documentation)
  • test (Test Coverage)
  • chore (Clean Up / Maintenance Tasks)
  • other (Anything that doesn't fit the above)

What this PR does / Why we need it?

IPs starting with 182. will be included in the AWS trust policy for proxy access

Which Jira/Github issue(s) does this PR fix?

  • Related Issue #
  • Closes #

Special notes for your reviewer

Unit Test Coverage

Guidelines

  • If it's a new sub-command or new function to an existing sub-command, please cover at least 50% of the code
  • If it's a bug fix for an existing sub-command, please cover 70% of the code

Test coverage checks

  • Added unit tests
  • Created jira card to add unit test
  • This PR may not need unit tests

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR
  • Backward compatible

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 2, 2025
@openshift-ci openshift-ci bot requested review from Tessg22 and xiaoyu74 December 2, 2025 23:45
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2025
@samanthajayasinghe samanthajayasinghe changed the title SREP-1739 fix : Add 182 prefix proxy IP to allowlist SREP-1739 fix : Add 182 prefix proxy IP to the allowlist in the AWS session policy Dec 2, 2025
@feichashao
Copy link
Contributor

feichashao commented Dec 2, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feichashao, samanthajayasinghe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [feichashao,samanthajayasinghe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2025

@samanthajayasinghe: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.91%. Comparing base (2cd31f2) to head (e266938).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #858   +/-   ##
=======================================
  Coverage   52.91%   52.91%           
=======================================
  Files          86       86           
  Lines        6524     6525    +1     
=======================================
+ Hits         3452     3453    +1     
  Misses       2610     2610           
  Partials      462      462
Files with missing lines Coverage Δ
cmd/ocm-backplane/cloud/common.go 56.21% <100.00%> (+0.13%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-merge-bot openshift-merge-bot bot merged commit 4c55f23 into openshift:main Dec 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tessg22 Tessg22 Awaiting requested review from Tessg22

@xiaoyu74 xiaoyu74 Awaiting requested review from xiaoyu74

Assignees

@feichashao feichashao

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samanthajayasinghe @feichashao @codecov-commenter