SREP-974: managed-script describe-nodes should accept parameters by environment variables#219
Conversation
|
@MateSaary: This pull request references SREP-974 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
|
@MateSaary: This pull request references SREP-974 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@MateSaary: This pull request references SREP-974 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MateSaary The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8112b13 to
dd2ce84
Compare
|
/hold cancel |
MateSaary
left a comment
There was a problem hiding this comment.
@Dee-6777 happy to report that backplane-cli v0.3.0 was released recently, so this PR is now good to go ahead 😄
dd2ce84 to
72a5f65
Compare
|
/lgtm |
|
/lgtm |
|
@MateSaary: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
feature
What this PR does / Why we need it?
This PR improves upon the
describe-nodescommand by accepting individual env variables as parameters, and as a direct follow-up for openshift/backplane-cli#731, invalid parameters or lack of essential parameters will now throw an error immediately instead of creating the job (and requiring the user to view logs to obtain source of the error).Which Jira/Github issue(s) does this PR fix?
Resolves # SREP-974
Special notes for your reviewer
Relies on openshift/backplane-cli#731, do not merge until promotion.
Pre-checks (if applicable)