Fix codecov-action params#349
Merged
openshift-merge-bot[bot] merged 1 commit intooperator-framework:masterfrom Jun 24, 2024
Merged
Fix codecov-action params#349openshift-merge-bot[bot] merged 1 commit intooperator-framework:masterfrom
openshift-merge-bot[bot] merged 1 commit intooperator-framework:masterfrom
Conversation
* `functionalities` param is no longer exist. It was used to enable file fixes to ignore common lines from coverage. This feature is now seems to be on by default. * Adding `disable_search` because we do not need for the codecov action to search for coverage files: we explicitly provide files. Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #349 +/- ##
=======================================
Coverage 39.43% 39.43%
=======================================
Files 56 56
Lines 4516 4516
=======================================
Hits 1781 1781
Misses 2581 2581
Partials 154 154 ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, m1kola, perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hongkailiu
pushed a commit
to hongkailiu/operator-framework-api
that referenced
this pull request
Jul 2, 2024
* `functionalities` param is no longer exist. It was used to enable file fixes to ignore common lines from coverage. This feature is now seems to be on by default. * Adding `disable_search` because we do not need for the codecov action to search for coverage files: we explicitly provide files. Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
functionalitiesparam is no longer exist. It was used to enable file fixes to ignore common lines from coverage. This feature is now seems to be on by default.Adding
disable_searchbecause we do not need for the codecov action to search for coverage files: we explicitly provide files.