feat(demo): Demo for drawer mode with display mode switcher#601
feat(demo): Demo for drawer mode with display mode switcher#601rebeccaalpert merged 6 commits intopatternfly:mainfrom
Conversation
|
Preview: https://chatbot-pr-chatbot-601.surge.sh A11y report: https://chatbot-pr-chatbot-601-a11y.surge.sh |
rebeccaalpert
left a comment
There was a problem hiding this comment.
Overall this looks good to me. There's two areas where I think we could improve a little bit (skip to content focus and unneeded drawer action), and one area I'd like to carve out into a separate issue (maintaining dropdown focus when container is changed). I left more detailed comments below, but please ping me if you have any questions!
packages/module/patternfly-docs/content/extensions/chatbot/examples/demos/Chatbot.md
Outdated
Show resolved
Hide resolved
...ages/module/patternfly-docs/content/extensions/chatbot/examples/demos/ChatbotDisplayMode.tsx
Outdated
Show resolved
Hide resolved
...ages/module/patternfly-docs/content/extensions/chatbot/examples/demos/ChatbotDisplayMode.tsx
Show resolved
Hide resolved
...ages/module/patternfly-docs/content/extensions/chatbot/examples/demos/ChatbotDisplayMode.tsx
Outdated
Show resolved
Hide resolved
edonehoo
left a comment
There was a problem hiding this comment.
just a few small suggestions, but generally this looks great!
packages/module/patternfly-docs/content/extensions/chatbot/examples/demos/Chatbot.md
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/demos/Chatbot.md
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/demos/Chatbot.md
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/demos/Chatbot.md
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/demos/Chatbot.md
Outdated
Show resolved
Hide resolved
|
Like Rebecca mentioned, we changed our terminology from "docked" to "drawer", but I'm realizing that we may need to go back at update the display options menu at a global level (rather than just in this pr) @rebeccaalpert ? Should we say "drawer" instead of "dock to window" for the menu item, since we're not using the term "docked" in our docs anymore |
kaylachumley
left a comment
There was a problem hiding this comment.
+1 on erin and rebeccas comments - design looks good! ty!
|
@edonehoo - It's not a global change. We can definitely update the wording in this one specific demo if you want it to be "Drawer." We haven't deprecated the other mode or removed it from other demos. |
|
@rebeccaalpert ahh okay thanks for clarifying! In that case, then yeah I think for this demo at least let's go with Drawer |
rebeccaalpert
left a comment
There was a problem hiding this comment.
Thank you so much for making all those changes! I just have one comment about this one unused case.
...ages/module/patternfly-docs/content/extensions/chatbot/examples/demos/ChatbotDisplayMode.tsx
Outdated
Show resolved
Hide resolved
rebeccaalpert
left a comment
There was a problem hiding this comment.
Looking great! Thank you so much for all those changes.
...ages/module/patternfly-docs/content/extensions/chatbot/examples/demos/ChatbotDisplayMode.tsx
Show resolved
Hide resolved
...ages/module/patternfly-docs/content/extensions/chatbot/examples/demos/ChatbotDisplayMode.tsx
Show resolved
Hide resolved
...ages/module/patternfly-docs/content/extensions/chatbot/examples/demos/ChatbotDisplayMode.tsx
Show resolved
Hide resolved
...ages/module/patternfly-docs/content/extensions/chatbot/examples/demos/ChatbotDisplayMode.tsx
Show resolved
Hide resolved
…ly#601) Adds demo for inline drawer functionality with display mode switcher to overlay and full screen.
Created a chatbot demo to show off the drawer mode with display mode switcher. Closes #508