feat(docs): add ISO download card demo#646
Conversation
|
Preview: https://chatbot-pr-chatbot-646.surge.sh A11y report: https://chatbot-pr-chatbot-646-a11y.surge.sh |
rebeccaalpert
left a comment
There was a problem hiding this comment.
Thank you! Looking good. Just a few notes about spacing. Would you also be able to move the ISODownloadCard example here instead?: https://chatbot-pr-chatbot-646.surge.sh/patternfly-ai/chatbot/messages#custom-message-content.
...patternfly-docs/content/extensions/chatbot/examples/Customizing Messages/ISODownloadCard.tsx
Outdated
Show resolved
Hide resolved
...patternfly-docs/content/extensions/chatbot/examples/Customizing Messages/ISODownloadCard.tsx
Outdated
Show resolved
Hide resolved
|
Ah sorry, I misunderstood you when I asked about where to put this before |
|
No worries at all - I didn't realize we had two very similarly named sections. 😅 |
Also tweak some styling to better align the example with the design
rebeccaalpert
left a comment
There was a problem hiding this comment.
Looks good to me! Let me tag some other folks, but thank you so much!
edonehoo
left a comment
There was a problem hiding this comment.
only one minor suggestion, looks good!
...patternfly-docs/content/extensions/chatbot/examples/Messages/UserMessageWithExtraContent.tsx
Outdated
Show resolved
Hide resolved
…mples/Messages/UserMessageWithExtraContent.tsx Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
kaylachumley
left a comment
There was a problem hiding this comment.
loooks good! Would it be possible to add this padding pf-t--global--spacer--gap--text-to-element--default between the icon and the heading title?
@srambach is there an appropriate way of doing this which doesn't require custom token setting? I'm looking through core and it seems like the only way that token gets applied on a card header is something to do with having a toggle, but I very well could be missing something |
|
🎉 This PR is included in version 6.4.0-prerelease.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
Closes #618
Currently the demo doesn't change the download button to a loading button due to what appears to be a bug in our Button component, but that would be easy to add down the road once that bug is resolved upstream.
Convenience link: https://chatbot-pr-chatbot-646.surge.sh/patternfly-ai/chatbot/messages#custom-message-content
Super convenience screenshot:
Assisted-by: Cursor running claude-4-sonnet