feat(ToolResponse): Add component#662
Merged
nicolethoen merged 6 commits intopatternfly:mainfrom Sep 5, 2025
Merged
Conversation
|
Preview: https://chatbot-pr-chatbot-662.surge.sh A11y report: https://chatbot-pr-chatbot-662-a11y.surge.sh |
99697fb to
774181e
Compare
774181e to
7802691
Compare
rebeccaalpert
commented
Aug 28, 2025
| '--pf-v6-c-expandable-section__content--Opacity': '1', | ||
| '--pf-v6-c-expandable-section__content--PaddingInlineStart': 0, | ||
| '--pf-v6-c-expandable-section__content--TranslateY': 0, | ||
| '--pf-v6-c-expandable-section--m-expand-top__content--TranslateY': 0 |
Member
Author
There was a problem hiding this comment.
edonehoo
suggested changes
Aug 29, 2025
Contributor
edonehoo
left a comment
There was a problem hiding this comment.
feel free to adjust my suggestions based on what's the most accurate! I wasn't sure, but wanted to leave some direction for replacing the lorem ipsum text
...ule/patternfly-docs/content/extensions/chatbot/examples/Messages/MessageWithToolResponse.tsx
Outdated
Show resolved
Hide resolved
...ule/patternfly-docs/content/extensions/chatbot/examples/Messages/MessageWithToolResponse.tsx
Outdated
Show resolved
Hide resolved
...ule/patternfly-docs/content/extensions/chatbot/examples/Messages/MessageWithToolResponse.tsx
Outdated
Show resolved
Hide resolved
...ule/patternfly-docs/content/extensions/chatbot/examples/Messages/MessageWithToolResponse.tsx
Outdated
Show resolved
Hide resolved
...ule/patternfly-docs/content/extensions/chatbot/examples/Messages/MessageWithToolResponse.tsx
Outdated
Show resolved
Hide resolved
...ule/patternfly-docs/content/extensions/chatbot/examples/Messages/MessageWithToolResponse.tsx
Outdated
Show resolved
Hide resolved
d706b7b to
fc2e132
Compare
edonehoo
suggested changes
Sep 3, 2025
Contributor
edonehoo
left a comment
There was a problem hiding this comment.
just making the other Tool name instances to be toolName, but if others prefer Tool name we can switch all those back 👍
...ule/patternfly-docs/content/extensions/chatbot/examples/Messages/MessageWithToolResponse.tsx
Outdated
Show resolved
Hide resolved
...ule/patternfly-docs/content/extensions/chatbot/examples/Messages/MessageWithToolResponse.tsx
Outdated
Show resolved
Hide resolved
edonehoo
approved these changes
Sep 3, 2025
07e25d3 to
8fe284b
Compare
...ule/patternfly-docs/content/extensions/chatbot/examples/Messages/MessageWithToolResponse.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+20
to
+22
| collapsedToggleText: string; | ||
| /** Toggle text shown on expandable section when it is expanded */ | ||
| expandedToggleText: string; |
Collaborator
There was a problem hiding this comment.
Would we want to expose both of these props on this base component, or instead just expose toggleContent and allow consumers to pass in these via the expandableSectionProps? At least in the example above it doesn't make sense to pass both of these in when the text remains the same.
Member
Author
There was a problem hiding this comment.
Good call-out! All set!
| <Card isCompact className="pf-chatbot__tool-response" {...cardProps}> | ||
| <CardBody {...cardBodyProps}> | ||
| <ExpandableSection | ||
| toggleText={isExpanded ? expandedToggleText : collapsedToggleText} |
Collaborator
There was a problem hiding this comment.
Couple nits:
- maybe using toggleContent instead? idk if we plan to deprecate toggleText, but toggleContent does what toggleText does but more)
- if we want to keep the 2 toggle props for expanded and collapsed, any reason to not pass those to the respective expanded/collapsedToggleText props instead?
Member
Author
There was a problem hiding this comment.
Also a good call-out and also all set!
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
1c25c1a to
52b3730
Compare
nicolethoen
approved these changes
Sep 5, 2025
thatblindgeye
approved these changes
Sep 5, 2025
|
🎉 This PR is included in version 6.4.0-prerelease.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new tool response component with demo and tests.
Here are some screenshots in situ:
Demo: https://chatbot-pr-chatbot-662.surge.sh/patternfly-ai/chatbot/messages#messages-with-tool-responses