feat(Message): Strip images from user messages by default#673
Merged
rebeccaalpert merged 1 commit intopatternfly:mainfrom Sep 19, 2025
Merged
feat(Message): Strip images from user messages by default#673rebeccaalpert merged 1 commit intopatternfly:mainfrom
rebeccaalpert merged 1 commit intopatternfly:mainfrom
Conversation
|
Preview: https://chatbot-pr-chatbot-673.surge.sh A11y report: https://chatbot-pr-chatbot-673-a11y.surge.sh |
fdbf8eb to
3aa1cd7
Compare
3aa1cd7 to
cb22d96
Compare
Collaborator
thatblindgeye
left a comment
There was a problem hiding this comment.
Just a nit below, not blocking so let me know what you think
Comment on lines
+206
to
+207
| /** Whether user messages default to stripping out images in markdown */ | ||
| hasNoImagesInUserMessages?: boolean; |
Collaborator
There was a problem hiding this comment.
This is just a nit, but wdyt about having this prop be the inverse and be something like "areImagesAllowed" or "hasImages"? Not totally sure if we'd need to note this is for user messages in the prop name, but just to try and make the prop name a tad more concise.
thatblindgeye
approved these changes
Sep 19, 2025
Collaborator
thatblindgeye
left a comment
There was a problem hiding this comment.
The above isn't a blocker for me, the PR looks good either way!
|
🎉 This PR is included in version 6.4.0-prerelease.25 🎉 The release is available on: Your semantic-release bot 📦🚀 |
rebeccaalpert
added a commit
to rebeccaalpert/virtual-assistant
that referenced
this pull request
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got sign-offs from everyone we know about.