feat(ToolResponse): Make card optional#680
Merged
rebeccaalpert merged 1 commit intopatternfly:mainfrom Sep 15, 2025
Merged
Conversation
|
Preview: https://chatbot-pr-chatbot-680.surge.sh A11y report: https://chatbot-pr-chatbot-680-a11y.surge.sh |
thatblindgeye
approved these changes
Sep 15, 2025
Collaborator
thatblindgeye
left a comment
There was a problem hiding this comment.
This lgtm, just one question below, but otherwise ✅
| <Divider {...toolResponseCardDividerProps} /> | ||
| <CardBody {...toolResponseCardBodyProps}>{cardBody}</CardBody> | ||
| </Card> | ||
| {cardTitle && cardBody && ( |
Collaborator
There was a problem hiding this comment.
Would we want to extend the ask a bit and allow rendering only title or body, rather than all-or-nothing?
Member
Author
There was a problem hiding this comment.
All set if you want to take a look!
20df808 to
7d9e723
Compare
thatblindgeye
approved these changes
Sep 15, 2025
|
🎉 This PR is included in version 6.4.0-prerelease.23 🎉 The release is available on: Your semantic-release bot 📦🚀 |
rebeccaalpert
added a commit
to rebeccaalpert/virtual-assistant
that referenced
this pull request
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ask from Shadowbot team to make the tool response card optional - easy for us to do and it's non-breaking.